feat: notify diego of route updates#4298
Merged
philippthun merged 4 commits intocloudfoundry:mainfrom Apr 16, 2025
Merged
Conversation
After updating a route via the new update route endpoint, it was only stored in the database. Since routes can be changed without restarting the application this commit adds logic to also push the update to diego. Resolves: cloudfoundry#4286 Co-Authored-By: Clemens Hoffmann <clemens.hoffmann@sap.com>
hoffmaen
force-pushed
the
maxmoehl/issue-4286
branch
from
49a566d to
52f18bf
Compare
philippthun
requested changes
Apr 11, 2025
Contributor
|
Thanks for the valuable feedback @philippthun ! |
philippthun
reviewed
Apr 16, 2025
Member
philippthun
left a comment
philippthun
left a comment
There was a problem hiding this comment.
One additional thing that came into my mind...
philippthun
approved these changes
Apr 16, 2025
ari-wg-gitbot
added a commit
to cloudfoundry/capi-release
that referenced
this pull request
Apr 16, 2025
Changes in cloud_controller_ng:
- feat: notify diego of route updates
PR: cloudfoundry/cloud_controller_ng#4298
Author: Maximilian Moehl <44866320+maxmoehl@users.noreply.github.com>
Author: Clemens Hoffmann <clemens.hoffmann@sap.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After updating a route via the new update route endpoint, it was only stored in the database. Since routes can be changed without restarting the application this commit adds logic to also push the update to diego.
Resolves: #4286
Thanks for contributing to cloud_controller_ng. To speed up the process of reviewing your pull request please provide us with:
A short explanation of the proposed change:
An explanation of the use cases your change solves
Links to any other associated PRs
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests